Expose configuration of exchange peer info timeout #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
added
enhancement
madsbk
approved these changes
Jan 21, 2025
Co-authored-by: Mads R. B. Kristensen <madsbk@gmail.com>
|
Thanks @madsbk ! |
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/rapids-dask-dependency
that referenced
this pull request
Jan 21, 2025
This feature is required for RAPIDS 25.02, therefore we cannot upstream and wait for a Distributed release on time for the RAPIDS release. The code here is a verbatim copy of [Distributed's ucx.py](https://github.com/dask/distributed/blob/2e61816b68296e823b69a83b6845e512b80bc524/distributed/comm/ucx.py), only adding a new variable `distributed.comm.ucx.connect-timeout` that allows controlling the timeout of UCX exchange peer info procedure (implemented in rapidsai/ucx-py#1103). Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Benjamin Zaitlen (https://github.com/quasiben) - GALI PREM SAGAR (https://github.com/galipremsagar) URL: #80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to configure the timeout of messages during exchange peer info via constructor argument and environment variable.
This feature is important in Distributed (see #994 for details), more so on larger scale clusters. A new configuration variable will be added to allow controlling this feature via Dask config and environment variables.