Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce pre-commit checks in CI, add verify-copyright hook #87

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#135

Working on #86, I ran pre-commit run --all-files locally and was surprised to see some unrelated changes made. It looks like this is because pre-commit checks aren't enforced in CI here.

This proposes the following:

  • update all pre-commit hooks to their latest versions (pre-commit autoupdate)
  • add shellcheck and verify-copyright hooks
  • enforce in CI that pre-commit must pass

This should slightly improve our confidence in ✅ from CI for this project.

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 18, 2025
@jameslamb jameslamb changed the title WIP: enforce pre-commit checks in CI, add verify-copyright hook enforce pre-commit checks in CI, add verify-copyright hook Feb 18, 2025
@jameslamb jameslamb requested a review from gforsyth February 18, 2025 19:45
@jameslamb jameslamb marked this pull request as ready for review February 18, 2025 19:45
@jameslamb jameslamb requested a review from a team as a code owner February 18, 2025 19:45
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 49676e9 into rapidsai:branch-25.04 Feb 19, 2025
12 checks passed
@jameslamb jameslamb deleted the run-precommit branch February 19, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants