remove conda-verify dependency #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
jameslamb
changed the title
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
Contributes to rapidsai/build-planning#135 Working on #86, I ran `pre-commit run --all-files` locally and was surprised to see some unrelated changes made. It looks like this is because `pre-commit` checks aren't enforced in CI here. This proposes the following: * update all pre-commit hooks to their latest versions (`pre-commit autoupdate`) * add `shellcheck` and `verify-copyright` hooks * enforce in CI that `pre-commit` must pass This should slightly improve our confidence in ✅ from CI for this project. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Gil Forsyth (https://github.com/gforsyth) - Tom Augspurger (https://github.com/TomAugspurger) URL: #87
bdice
approved these changes
Feb 19, 2025
jakirkham
approved these changes
Feb 19, 2025
|
/merge |
|
Thanks James and Bradley! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#150
Proposes removing
host:dependency onconda-verify. See the discussion in rapidsai/rapids-metadata#43 for background.