Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] nvcc issuing unrecognized GCC pragma in fmt compiling libcudf in debug mode #454

Closed
cryos opened this issue Aug 24, 2023 · 1 comment · Fixed by #456
Closed

[BUG] nvcc issuing unrecognized GCC pragma in fmt compiling libcudf in debug mode #454

cryos opened this issue Aug 24, 2023 · 1 comment · Fixed by #456
Assignees
@robertmaynard
Labels
2 - In Progress Currenty a work in progress bug Something isn't working

Comments

@cryos
Copy link

cryos commented Aug 24, 2023

Describe the bug
I am hitting issues with "src/cudf/cpp/build/_deps/fmt-src/include/fmt/core.h(290): error #1675-D: unrecognized GCC pragma" when attempting to build libcudf in debug mode using the FMT provided by rapids-cmake/CPM. This is using the system compiler (GCC 11.4.0) with CUDA 11.8.

Steps/Code to reproduce bug

git clone https://github.com/rapidsai/cudf.git
cd cudf
./build.sh -n -g libcudf

This results in compiler errors such as:

1 error detected in the compilation of "/src/cudf/cpp/src/binaryop/compiled/Add.cu".
/src/cudf/cpp/build/_deps/fmt-src/include/fmt/core.h(290): error #1675-D: unrecognized GCC pragma

Expected behavior
Compilation to succeed as the default release mode does.

Environment details (please complete the following information):

  • Environment location: Bare-metal
  • CMake version: 3.27.1
  • OS: Ubuntu 22.04
@cryos cryos added ? - Needs Triage Need team to review and classify bug Something isn't working labels Aug 24, 2023
@robertmaynard robertmaynard self-assigned this Aug 25, 2023
@robertmaynard robertmaynard added 1 - On Deck To be worked on next 2 - In Progress Currenty a work in progress and removed ? - Needs Triage Need team to review and classify 1 - On Deck To be worked on next labels Aug 25, 2023
robertmaynard added a commit to robertmaynard/rapids-cmake that referenced this issue Sep 1, 2023
@robertmaynard
Support fmt use in debug builds
65c7552 
Fixes rapidsai#454
@robertmaynard robertmaynard mentioned this issue Sep 1, 2023
Merged
4 tasks
@rapids-bot rapids-bot bot closed this as completed in #456 Sep 5, 2023
rapids-bot bot pushed a commit that referenced this issue Sep 5, 2023
@robertmaynard
Support fmt use in debug builds (#456)
9a2cfe8 
Fixes #454

Backport of an upstream patch (fmtlib/fmt#3352) to our version of fmt 9.1

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #456
@cryos
Copy link
Author

cryos commented Sep 6, 2023

Excellent - thanks for the prompt fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertmaynard robertmaynard

Labels
2 - In Progress Currenty a work in progress bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support fmt use in debug builds robertmaynard/rapids-cmake
2 participants
@cryos @robertmaynard