From 1b6380fd6ee17ec47a235c321830a9de65e89bc6 Mon Sep 17 00:00:00 2001 From: Mike McCarty Date: Fri, 26 Jul 2024 16:42:33 -0400 Subject: [PATCH 1/2] Fixed link to build docs and corrected ivf_flat_example note for handles to resources kwarg change. --- README.md | 2 +- notebooks/ivf_flat_example.ipynb | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 23856060d..e1e7706d1 100755 --- a/README.md +++ b/README.md @@ -53,7 +53,7 @@ If installing a version that has not yet been released, the `rapidsai` channel c mamba install -c conda-forge -c nvidia -c rapidsai-nightly cuvs=24.10 ``` -Please see the [Build and Install Guide](docs/source/build.md) for more information on installing cuVS and building from source. +Please see the [Build and Install Guide](docs/source/build.rst) for more information on installing cuVS and building from source. ## Getting Started diff --git a/notebooks/ivf_flat_example.ipynb b/notebooks/ivf_flat_example.ipynb index 38bacb8a7..2d9c5fb58 100644 --- a/notebooks/ivf_flat_example.ipynb +++ b/notebooks/ivf_flat_example.ipynb @@ -216,7 +216,7 @@ "search_params = ivf_flat.SearchParams(n_probes=30)\n", "\n", "# Search 10 nearest neighbors.\n", - "distances, indices = ivf_flat.search(search_params, index, cp.asarray(queries[:n_queries,:]), k=10, handle=handle)\n", + "distances, indices = ivf_flat.search(search_params, index, cp.asarray(queries[:n_queries,:]), k=10, resources=handle)\n", " \n", "# cuVS calls are asynchronous (when handle arg is provided), we need to sync before accessing the results.\n", "handle.sync()\n", @@ -302,7 +302,7 @@ " index,\n", " cp.asarray(queries),\n", " k=10,\n", - " handle=handle,\n", + " resources=handle,\n", " )\n", " handle.sync()\n", " \n", @@ -382,7 +382,7 @@ " add_data_on_build=True\n", " )\n", "\n", - "index = ivf_flat.build(build_params, dataset, handle=handle)" + "index = ivf_flat.build(build_params, dataset, resources=handle)" ] }, { @@ -406,7 +406,7 @@ "search_params = ivf_flat.SearchParams(n_probes=10)\n", "\n", "# Search 10 nearest neighbors.\n", - "distances, indices = ivf_flat.search(search_params, index, cp.asarray(queries[:n_queries,:]), k=10, handle=handle)\n", + "distances, indices = ivf_flat.search(search_params, index, cp.asarray(queries[:n_queries,:]), k=10, resources=handle)\n", " \n", "handle.sync()\n", "distances, neighbors = cp.asnumpy(distances), cp.asnumpy(indices)" @@ -445,7 +445,7 @@ " kmeans_trainset_fraction=0.1, \n", " kmeans_n_iters=20 \n", " ) \n", - "index = ivf_flat.build(build_params, dataset, handle=handle)" + "index = ivf_flat.build(build_params, dataset, resources=handle)" ] }, { @@ -465,7 +465,7 @@ "source": [ "search_params = ivf_flat.SearchParams(n_probes=10)\n", "\n", - "distances, indices = ivf_flat.search(search_params, index, cp.asarray(queries[:n_queries,:]), k=10, handle=handle)\n", + "distances, indices = ivf_flat.search(search_params, index, cp.asarray(queries[:n_queries,:]), k=10, resources=handle)\n", " \n", "handle.sync()\n", "distances, neighbors = cp.asnumpy(distances), cp.asnumpy(indices)\n", From 3178e84b4efd383ac28784e8f74f5516589acdd8 Mon Sep 17 00:00:00 2001 From: Mike McCarty Date: Mon, 29 Jul 2024 13:04:56 -0400 Subject: [PATCH 2/2] Linking directly to rendered docs for build structions --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e1e7706d1..543ce941c 100755 --- a/README.md +++ b/README.md @@ -53,7 +53,7 @@ If installing a version that has not yet been released, the `rapidsai` channel c mamba install -c conda-forge -c nvidia -c rapidsai-nightly cuvs=24.10 ``` -Please see the [Build and Install Guide](docs/source/build.rst) for more information on installing cuVS and building from source. +Please see the [Build and Install Guide](https://docs.rapids.ai/api/cuvs/stable/build/) for more information on installing cuVS and building from source. ## Getting Started