Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: ST_distance improvement: consolidate existing APIs #1056

Closed
2 tasks done
isVoid opened this issue Apr 7, 2023 · 1 comment
Closed
2 tasks done

[FEA]: ST_distance improvement: consolidate existing APIs #1056

isVoid opened this issue Apr 7, 2023 · 1 comment
Assignees
Labels
feature request New feature or request

Comments

@isVoid
Copy link
Contributor

isVoid commented Apr 7, 2023

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem you would like to solve.

There are dependencies between st_distance kernels, as shown in the following diagram:
image

The current implementation of st_distance kernels are siloed and lackes reusing overlapping logics. A refactor should happen to facilitate these dependencies.

Second, several implementation in kernels are not load balanced if the input is skewed. This can lead to unwanted performance degradation. As experimented in #1011, it is possible to create a perfectly load balanced kernel for any input geometries. It should be adopted for other distance API too.

Describe any alternatives you have considered

No response

Additional context

No response

Tasks

Preview Give feedback
  1. isVoid
  2. isVoid
@isVoid isVoid added feature request New feature or request Needs Triage Need team to review and classify labels Apr 7, 2023
@github-project-automation github-project-automation bot moved this to Todo in cuSpatial Apr 7, 2023
@isVoid isVoid self-assigned this Apr 7, 2023
@jarmak-nv jarmak-nv removed the Needs Triage Need team to review and classify label Apr 27, 2023
@isVoid isVoid moved this from Todo to Review in cuSpatial May 30, 2023
@isVoid
Copy link
Contributor Author

isVoid commented Jun 5, 2023

Originally, #1061 is considered part of this milestone issue. However, #1061 is mainly about optimization on existing distance kernel performance, while this issue requests architecture wise improvement. I decided that they are unrelated issues. Thus removing 1061 from the list above.

Since all underlying issue for this milestone is closed, closing this milestone.

@isVoid isVoid closed this as completed Jun 5, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in cuSpatial Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants