Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document all simple and single geometric special cases #1036

Closed
thomcom opened this issue Apr 5, 2023 · 0 comments · Fixed by #1085
Closed

Document all simple and single geometric special cases #1036

thomcom opened this issue Apr 5, 2023 · 0 comments · Fixed by #1085
Assignees
Labels
2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Milestone

Comments

@thomcom
Copy link
Contributor

thomcom commented Apr 5, 2023

Closed by #1064

This task is for documenting and planning special cases that need to be tested among binary predicates, such as tests with polygons with holes and linestring and polygon crossings.

There are many special cases of polygons that will need to have tests written for them. I'm writing a suite of special case tests to handle all possible configurations of geometric relations between two features.

See https://github.com/thomcom/spatial-predicates

#1064 implements 33 unique test cases for the three basic types: point, linestring, and polygon. The tests are run with each of the binary predicates and are used for developing each feature.

A future issue and PR will track the creation and validation of multi-geometry feature predicates.
Another future issue will track the execution of any special cases that don't fall into the original 33, if any are discovered.

Originally posted by @thomcom in #1016 (comment)

@github-project-automation github-project-automation bot moved this to Todo in cuSpatial Apr 5, 2023
@thomcom thomcom self-assigned this Apr 5, 2023
@thomcom thomcom added 1 - On Deck To be worked on next improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 5, 2023
@thomcom thomcom changed the title Document and test all geometric special cases Document and all geometric special cases Apr 5, 2023
@thomcom thomcom added this to the DE-9IM milestone Apr 5, 2023
@thomcom thomcom changed the title Document and all geometric special cases Document all geometric special cases Apr 5, 2023
@thomcom thomcom moved this from Todo to In Progress in cuSpatial Apr 6, 2023
@thomcom thomcom added 2 - In Progress Currenty a work in progress and removed 1 - On Deck To be worked on next labels Apr 6, 2023
@thomcom thomcom moved this from In Progress to Review in cuSpatial Apr 7, 2023
@thomcom thomcom moved this from Review to In Progress in cuSpatial Apr 7, 2023
@thomcom thomcom changed the title Document all geometric special cases Document all simple and single geometric special cases Apr 14, 2023
@thomcom thomcom moved this from In Progress to Review in cuSpatial Apr 14, 2023
@rapids-bot rapids-bot bot closed this as completed in 959cfdb Apr 26, 2023
@github-project-automation github-project-automation bot moved this from Review to Done in cuSpatial Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
1 participant