From d6056d24862bcd1a1a7df6d205a3db2c28e3e04e Mon Sep 17 00:00:00 2001 From: Ramakrishna Prabhu Date: Tue, 26 Jan 2021 12:27:36 -0600 Subject: [PATCH 1/2] fix benchmarks --- cpp/benchmarks/io/parquet/parquet_writer_benchmark.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/cpp/benchmarks/io/parquet/parquet_writer_benchmark.cpp b/cpp/benchmarks/io/parquet/parquet_writer_benchmark.cpp index 6006be505bc..8549236e18d 100644 --- a/cpp/benchmarks/io/parquet/parquet_writer_benchmark.cpp +++ b/cpp/benchmarks/io/parquet/parquet_writer_benchmark.cpp @@ -63,9 +63,9 @@ void BM_parq_write_varying_inout(benchmark::State& state) void BM_parq_write_varying_options(benchmark::State& state) { - auto const compression = static_cast(state.range(0)); - auto const enable_stats = static_cast(state.range(1)); - auto const output_metadata = state.range(2) != 0; + auto const compression = static_cast(state.range(0)); + auto const enable_stats = static_cast(state.range(1)); + auto const file_path = state.range(2) != 0 ? "dummy_path.parquet" : ""; auto const data_types = get_type_or_group({int32_t(type_group_id::INTEGRAL_SIGNED), int32_t(type_group_id::FLOATING_POINT), @@ -82,8 +82,7 @@ void BM_parq_write_varying_options(benchmark::State& state) cudf_io::parquet_writer_options::builder(source_sink.make_sink_info(), view) .compression(compression) .stats_level(enable_stats) - .return_filemetadata(output_metadata) - .column_chunks_file_path("dummy_path.parquet"); + .column_chunks_file_path(file_path); cudf_io::write_parquet(options); } From 41c7eff24067700850f6556d0d43547955696324 Mon Sep 17 00:00:00 2001 From: Ramakrishna Prabhu Date: Tue, 26 Jan 2021 12:40:42 -0600 Subject: [PATCH 2/2] review changes --- cpp/benchmarks/io/parquet/parquet_writer_benchmark.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/benchmarks/io/parquet/parquet_writer_benchmark.cpp b/cpp/benchmarks/io/parquet/parquet_writer_benchmark.cpp index 8549236e18d..d17e7b126c7 100644 --- a/cpp/benchmarks/io/parquet/parquet_writer_benchmark.cpp +++ b/cpp/benchmarks/io/parquet/parquet_writer_benchmark.cpp @@ -65,7 +65,7 @@ void BM_parq_write_varying_options(benchmark::State& state) { auto const compression = static_cast(state.range(0)); auto const enable_stats = static_cast(state.range(1)); - auto const file_path = state.range(2) != 0 ? "dummy_path.parquet" : ""; + auto const file_path = state.range(2) != 0 ? "unused_path.parquet" : ""; auto const data_types = get_type_or_group({int32_t(type_group_id::INTEGRAL_SIGNED), int32_t(type_group_id::FLOATING_POINT),