From 7ca6a8cfb40291d28dbd0a99e00275e1b4fc869b Mon Sep 17 00:00:00 2001 From: James Lamb Date: Fri, 23 Aug 2024 16:53:59 -0400 Subject: [PATCH] fix libcudf wheel publishing, make package-type explicit in wheel publishing (#16650) Follow-up to #15483. Contributes to https://github.com/rapidsai/build-planning/issues/33 Wheel publishing for `libcudf` is failing like this: ```text Error: File "./dist/*.whl" does not exist ``` ([build link](https://github.com/rapidsai/cudf/actions/runs/10528569930/job/29176811683)) Because the `package-type` was not set to `cpp` in the `wheels-publish` CI workflow, and that workflow defaults to `python`. ([shared-workflows code link](https://github.com/rapidsai/shared-workflows/blob/157e9824e6e2181fca9aa5c4bea4defd4cc322b0/.github/workflows/wheels-publish.yaml#L23-L26)). This fixes that, and makes that choice explicit for all wheel publishing jobs. References for this `package-type` argument: * https://github.com/rapidsai/shared-workflows/pull/209 * https://github.com/rapidsai/gha-tools/pull/105 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) URL: https://github.com/rapidsai/cudf/pull/16650 --- .github/workflows/build.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 0ea4d5c54dc..72daff7b66b 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -86,6 +86,7 @@ jobs: sha: ${{ inputs.sha }} date: ${{ inputs.date }} package-name: libcudf + package-type: cpp wheel-build-pylibcudf: needs: [wheel-publish-libcudf] secrets: inherit @@ -106,6 +107,7 @@ jobs: sha: ${{ inputs.sha }} date: ${{ inputs.date }} package-name: pylibcudf + package-type: python wheel-build-cudf: needs: wheel-publish-pylibcudf secrets: inherit @@ -126,6 +128,7 @@ jobs: sha: ${{ inputs.sha }} date: ${{ inputs.date }} package-name: cudf + package-type: python wheel-build-dask-cudf: needs: wheel-publish-cudf secrets: inherit @@ -148,6 +151,7 @@ jobs: sha: ${{ inputs.sha }} date: ${{ inputs.date }} package-name: dask_cudf + package-type: python wheel-build-cudf-polars: needs: wheel-publish-pylibcudf secrets: inherit @@ -170,6 +174,7 @@ jobs: sha: ${{ inputs.sha }} date: ${{ inputs.date }} package-name: cudf_polars + package-type: python trigger-pandas-tests: if: inputs.build_type == 'nightly' needs: wheel-build-cudf