Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Support pod selector in drain options #40003

Closed
bk201 opened this issue Dec 26, 2022 · 4 comments
Closed

[RFE] Support pod selector in drain options #40003

bk201 opened this issue Dec 26, 2022 · 4 comments
Labels
area/harvester area/provisioning-v2 Provisioning issues that are specific to the provisioningv2 generating framework kind/enhancement Issues that improve or augment existing functionality status/stale team/hostbusters The team that is responsible for provisioning/managing downstream clusters + K8s version support

Comments

@bk201
Copy link
Member

bk201 commented Dec 26, 2022

Is your feature request related to a problem? Please describe.

Longhorn doc advises that users should drain a node with --pod-selector='app!=csi-attacher,app!=csi-provisioner'. But the pod selector is not supported in drain options. Harvester relies on Rancher to upgrade the underlying RKE2 stack and would like to have this feature.

Describe the solution you'd like
Support passing pod selector (same as kubectl drain --pod-selector) when draining a node.

Describe alternatives you've considered
I can't find a workaround.

Additional context
Add any other context or screenshots about the feature request here.

@brandond
Copy link
Member

brandond commented Mar 24, 2023

`rancher/system-upgrade-controller:v0.11.0-dev.1 is available for testing. If you're able to give it a try, please do so. If it meets your needs I can tag a non-dev release.
Edit: v0.11.0 is now out.

@Sahota1225 Sahota1225 added the team/hostbusters The team that is responsible for provisioning/managing downstream clusters + K8s version support label May 17, 2023
@snasovich snasovich removed this from the 2023-Q3-v2.7x milestone Jun 26, 2023
@github-actions
Copy link
Contributor

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

@brandond
Copy link
Member

Not stale. Now implement in the controller, needs to be used in Rancher.

@github-actions
Copy link
Contributor

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/harvester area/provisioning-v2 Provisioning issues that are specific to the provisioningv2 generating framework kind/enhancement Issues that improve or augment existing functionality status/stale team/hostbusters The team that is responsible for provisioning/managing downstream clusters + K8s version support
Projects
None yet
Development

No branches or pull requests

4 participants