Remove cert-manager step from main installation #949
+77
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck in telemetry checklists
jordojordo
force-pushed
the
cert-manager-removal
branch
from
d78daac
to
2187a43
Compare
|
I am not sure we should require this.
Just my point of view, otherwise PR works OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #839
This removes the cert-manager check and installation step during the initial installation of Kubewarden.
Since cert-manager is required for OpenTelemetry, which is used for tracing and metrics, an extra step at the beginning of each telemetry checklist has been added to check for the existence of the cert-manager service.