Block deletion of machines from "inventory of machines" if they are part of a cluster or delete them from the cluster as well

[Martin-Weiss]

At the moment the process of deleting machines from "inventory of machines" once they are part of a cluster does not remove them from the cluster. At least not properly.

Deleting machines on the cluster side of things deletes them on the machine side of things..

So this is not very consistent and should be improved.

Either deletion on both sides should work or if supported only on one side - the other side should block the user.

[Martin-Weiss]

I would even like the option to remove a machine from one cluster and then add it to another cluster. So not sure why we remove the inventory completely when we delete the machine from a cluster..

[aalves08]

@davidcassany can we delete "inventory of machines" from a cluster from the UI or should we just block the deletion of the "inventory of machines" resource on the UI?

[anmazzotti]

I think it's better to just block the deletion of machine inventories from the UI.
However this can also be problematic, especially when manually fixing unexpected conditions.

The documentation for the Reset already points out the Rancher default UI.
The specific Elemental UI is not used for this scenario: https://elemental.docs.rancher.com/reset#machine-reset

[aalves08]

As per Slack conversation, was agreed on the following:
the delete button can be disabled only for machine inventories that have a "AdoptionReady" true condition

Last Transition Time:  2024-02-23T11:52:43Z
Message:               Successfully adopted
Reason:                SuccessfullyAdopted
Status:                True
Type:                  AdoptionReady

[juadk]

Tested successfully with elemental ui extension 1.3.1-rc2:

• With AdoptionReady set to False:

    - lastTransitionTime: '2024-03-19T08:42:00Z'
      message: Waiting to be adopted
      reason: WaitingToBeAdopted
      status: 'False'
      type: AdoptionReady

The machine inventory above can be deleted.

• With AdoptionReady to True:

    - lastTransitionTime: '2024-03-19T08:49:31Z'
      message: Successfully adopted
      reason: SuccessfullyAdopted
      status: 'True'
      type: AdoptionReady

The machine inventory above cannot be deleted as expected.