Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Fix keyboard navigation and focus display issues on the combobox component #12795

Open
Tracked by #7967
nwmac opened this issue Dec 4, 2024 · 0 comments
Open
Tracked by #7967

Comments

@nwmac
Copy link
Member

nwmac commented Dec 4, 2024

a11y Issues: 79, 20

Issue 79

Identical and inappropriate label is specified for the comboboxes resulted in screen reader users finding it difficult to understand the purpose of the comboboxes effectively.

Used in many places:

Preferences
Search for options label given for

  • Language
  • Take me to cluster:
  • Date format
  • Time format

Create API Key
Search for options for

  • Scope

Import YAML
Search for options for

  • Default Namespace

Git Repo - Add Repository
Search for options label given for

  • Watch
  • Git Authentication
  • HELM authentication
  • TLS certificate verification
  • Target (which gets available on activating "Next" button)

Pod Security Admission: Create
Search for options label given for

  • Enforce
  • Audit
  • Warn

Repository: Create
Search for options label given for

  • Authentication (which gets available on activating "http(s) URL to an index generated by Helm", "http(s) URL to an index generated by Helm" and "OCI Repository Experimental" radio buttons)

Import Extension Catalog
Search for options label given for

  • Image Pull Secrets

Banners

  • Header Banner section
  • Footer banner section
  • Login screen Banner section
    Search for options label given for
    • Font Size
      Example:

image

Remediation:

Apply the following changes:
• Remove "aria-label" attribute from source code of mentioned comboboxes.
• Specify "id" attribute with unique value to HTML elements containing text such as "Language", "Take me to cluster:", "Date Format", "Time Format" and "Table Rows per Page".
• Specify "aria-labelledby" attribute to

element containing combobox.
• Reference the "id" attribute values (of HTML elements) via "aria-labelledby" attribute respectively.

Issue 20 - Combobox displayed on keyboard focus

Combobox options gets displayed automatically when the mentioned combobox receives the keyboard focus resulting in keyboard-only and screen reader users will have to navigate through the options even when not required.

image

Remediiation:

Ensure that the combobox options do not get displayed automatically when the combobox receive the keyboard focus. It should get displayed when user activates the combobox.

@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Dec 4, 2024
@nwmac nwmac added area/accessibility size/2 Size Estimate 2 and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Dec 4, 2024
@nwmac nwmac added this to the v2.11.0 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants