Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y: Fix keyboard navigation and focus display for about page #12786

Closed
nwmac opened this issue Dec 4, 2024 · 4 comments · Fixed by #12959
Closed

a11y: Fix keyboard navigation and focus display for about page #12786

nwmac opened this issue Dec 4, 2024 · 4 comments · Fixed by #12959
Assignees
Labels
area/accessibility kind/enhancement priority/0 QA/manual-test Indicates issue requires manually testing size/1 Size Estimate 1
Milestone

Comments

@nwmac
Copy link
Member

nwmac commented Dec 4, 2024

a11y Issue: 215

The about page (see below) does not show keyboard focus and does not response to keyboard navigation.

The download links are not in the tab order.

image

Generally need to check the tab order through the page.

Focus display for the primary 'Diagnostics' button needs to be checked.

@nwmac nwmac added this to the v2.11.0 milestone Dec 4, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Dec 4, 2024
@aalves08 aalves08 self-assigned this Dec 30, 2024
@aalves08 aalves08 added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Jan 3, 2025
@yonasberhe23
Copy link
Contributor

Needs manual validation at this time as we dont have existing accessiblity tests. Follow-up ticket to create automated tests coverage rancher/qa-tasks#1639

@IsaSih IsaSih self-assigned this Jan 13, 2025
@IsaSih
Copy link
Contributor

IsaSih commented Jan 15, 2025

Navigation using tab and return work as expected in
Rancher | v2.11-1e40bc40c55a020fc67dc3c3dde47b41dc94caf1-head
Dashboard | master 574248d
Rancher CLI | v2.11.0-rc.1
Helm | dev
Machine | v0.15.0-rancher125

However, the space bar does not perform click actions in elements inside the table.
Just want to confirm @nwmac if this is working as expected? I reopened the issue because I believe that space should also perform the same actions as the return/enter keyboard shortcut

@aalves08
Copy link
Member

The decision made is that "links" that appear as buttons are to have the space key as trigger as simple links, anchors, non-button links should not have the space key as trigger, as per #12959 (comment) + #12959 (comment)

@IsaSih
Copy link
Contributor

IsaSih commented Jan 28, 2025

Then, the accessibility behavior is working as expected. Closing the issue

@IsaSih IsaSih closed this as completed Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/accessibility kind/enhancement priority/0 QA/manual-test Indicates issue requires manually testing size/1 Size Estimate 1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants