Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYPI tarball does not include dependencies dir #98

Closed
MatthewZMD opened this issue Dec 5, 2022 · 5 comments · Fixed by #101
Closed

PYPI tarball does not include dependencies dir #98

MatthewZMD opened this issue Dec 5, 2022 · 5 comments · Fixed by #101

Comments

@MatthewZMD
Copy link

Hey folks, is the PYPI release maintained by you too? Apparently it does not contain dependencies/build-requirements.txt, using the PYPI release will fail setup.py that explicitly required dependencies/build-requirements.txt

FileNotFoundError: [Errno 2] No such file or directory: '.../nptyping-2.3.1/dependencies/build-requirements.txt'
@ramonhagenaars
Copy link
Owner

Hi @MatthewZMD ! Thanks for pointing this out, this doesn't seem right.

@rhurlin
Copy link

rhurlin commented Feb 4, 2023

Any chance to get a new PyPi version with the dependencies directory in the near future?

BTW, it would be nice if this would happen for the tests directory as well, since systems like FreeBSD use the tests in their ports and packages. I'm preparing a port for nptyping and would like to integrate the tests ;)

Thank you for your understanding!
Rainer

@ramonhagenaars
Copy link
Owner

Hi folks.

Starting with release 2.5.0 (in the making), the distribution will include the requirement files, tests, etc.

@rhurlin
Copy link

rhurlin commented Feb 12, 2023

Hi @ramonhagenaars,
Many thanks! Really appreciated. I will use it in my next packaging on FreeBSD, after 2.5.0 is released.

@ramonhagenaars
Copy link
Owner

With v2.5.0 this issue should be resolved. Please let me know if you encounter any problems still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants