Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Option to make PINs visible in the generated UI #45

Closed
tykeal opened this issue Mar 2, 2024 · 12 comments
Closed

[Feature Request] Option to make PINs visible in the generated UI #45

tykeal opened this issue Mar 2, 2024 · 12 comments

Comments

@tykeal
Copy link
Contributor

tykeal commented Mar 2, 2024

Currently the only way to find out what PIN is assigned to a slot is to inspect the lock via ZWaveJS-UI or the diagnostic that is added to the lock (note this does not seem to always stay in sync!)

It would be nice to have an option in the UI to display the PIN instead of always being hidden. Perhaps a toggle just below the PIN field for Show / Hide PIN that defaults to off.

@chelming
Copy link

chelming commented Mar 4, 2024

is this fixed-ish? it seems that text.code_slot_1_pin exists and can display it now?

@raman325
Copy link
Owner

raman325 commented Mar 4, 2024

the concern I believ eis what shows in the UI. The state of the entity is not hidden, and if you click on the entity itself to pop up the modal, you should see the value. Is this sufficient or do you think the UI should have this capability? I wonder if this is more of a feature request upstream to have a "show" icon on password fields

@tykeal
Copy link
Contributor Author

tykeal commented Mar 4, 2024

Personally, I'm the only one that accesses anything that displays PINs and I need fairly easy access to the defined PIN when I'm informing my STR guests what their door code is. I don't really want to have to click around too much, especially since I'm regularly having to copy the current PIN when I'm using my phone and not at my computer.

Keymaster has a config option to hide pins or not hide pins for the generate dashboard. So, maybe a similar option. would be good?

@tykeal
Copy link
Contributor Author

tykeal commented Mar 4, 2024

I'll also note that while I can see it in the modal popup in the history graph, assuming it's been on long enough, there's no way to copy it.

@chelming
Copy link

chelming commented Mar 4, 2024

You can copy from the modal that appears when you click the code slot sensor

@tykeal
Copy link
Contributor Author

tykeal commented Mar 4, 2024

I can't, because my modal pops up with the slot sensor still as a password display. This is on a very, very stock testing system. It only has a few integrations and UI components from HACS, so this is what most folks are going to run into

@chelming
Copy link

chelming commented Mar 4, 2024

Oh, interesting. My keymaster integration is that way but my lock code manager has a sensor that isn't set to mode: password.

@tykeal
Copy link
Contributor Author

tykeal commented Mar 4, 2024

There's a diagnostic sensor that is getting created by LCM that is visible, but it's not on the generated dashboard. I suppose I could cobble something up personally that uses that, but it's not really the point of my feature request here ;)

@chelming
Copy link

chelming commented Mar 4, 2024

I'm getting it on the generated dashboard if I set include_code_slot_sensors: true in the strategy

@chelming
Copy link

chelming commented Mar 4, 2024

E.g.,
image

@chelming
Copy link

chelming commented Mar 4, 2024

obviously "fake" has an actual number in it and has been redacted for the screenshot 😅

@tykeal
Copy link
Contributor Author

tykeal commented Mar 4, 2024

Ah, I do have that. Looks like I overlooked it since it was below the fold. Nevermind, I can close this. It's fine with that then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants