Skip to content

Commit

Permalink
Conditionally filter pull requests, too, if github.filter_pull_reques…
Browse files Browse the repository at this point in the history
…ts is true.
  • Loading branch information
Adam Coddington committed Aug 22, 2014
1 parent 1373df6 commit 469d14d
Showing 1 changed file with 13 additions and 4 deletions.
17 changes: 13 additions & 4 deletions bugwarrior/services/github.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ def __init__(self, *args, **kw):
self.label_template = self.config_get_default(
'label_template', default='{{label}}', to_type=six.text_type
)
self.filter_pull_requests = self.config_get_default(
'filter_pull_requests', default=False, to_type=asbool
)

def get_service_metadata(self):
return {
Expand Down Expand Up @@ -238,13 +241,20 @@ def issues(self):
self.get_owned_repo_issues(user + "/" + repo['name'])
)
issues.update(self.get_directly_assigned_issues())
log.name(self.target).debug(" Found {0} total.", len(issues))
log.name(self.target).debug(" Found {0} issues total.", len(issues))
issues = filter(self.include, issues.values())
log.name(self.target).debug(" Pruned down to {0}", len(issues))
log.name(self.target).debug(" Pruned down to {0} issues", len(issues))

# Next, get all the pull requests (and don't prune)
# Next, get all the pull requests (and don't prune by default)
repos = filter(self.filter_repos_for_prs, all_repos)
requests = sum([self._reqs(user + "/" + r['name']) for r in repos], [])
log.name(self.target).debug(" Found {0} pull requests", len(requests))
if self.filter_pull_requests:
requests = filter(self.include, requests)
log.name(self.target).debug(
" Pruned down to {0} pull requests",
len(requests)
)

# For pull requests, github lists an 'issue' and a 'pull request' with
# the same id and the same URL. So, if we find any pull requests,
Expand All @@ -253,7 +263,6 @@ def issues(self):
request_urls = [r[1]['html_url'] for r in requests]

issues = [i for i in issues if not i[1]['html_url'] in request_urls]
log.name(self.target).debug(" Added {0} pull requests", len(requests))

for tag, issue in issues:
extra = {
Expand Down

0 comments on commit 469d14d

Please sign in to comment.