Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement remaining transit endpoints. #251

Merged
merged 4 commits into from
May 17, 2022

Conversation

jcpreston26
Copy link
Contributor

Hello,

I had a project using VaultSharp that was looking to expand to use some of the endpoints in the transit secrets engine that had yet to be implemented. In order to complete the project, I implemented those calls and am requesting them be pulled in. Please review.

Thanks!

@hoerup hoerup self-requested a review May 17, 2022 10:08
Copy link
Collaborator

@hoerup hoerup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoerup hoerup merged commit 79af6f4 into rajanadar:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants