Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for IVaultClient registration in DI #236

Closed
AleksandreJavakhishvili opened this issue Nov 26, 2021 · 2 comments
Closed

Documentation for IVaultClient registration in DI #236

AleksandreJavakhishvili opened this issue Nov 26, 2021 · 2 comments

Comments

@AleksandreJavakhishvili

Describe the feature request or question
With the current documentation It is not clear how we should register IVaultClient in DI with scoped/transient or singleton scope, I mistakenly added as a singleton, which ended up to have one instance of VaultClient and as It doesn't support token refresh we got {"errors":["permission denied"]} after 24h, It would be better If we add DI section in README.md.

@rajanadar
Copy link
Owner

done @AleksandreJavakhishvili

@rajanadar
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants