Add Method to ResetToken when max ttl is reached #161
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, i'am using the library and i face the problem of token ttl.
I'am using .net core and i'am setting the IVaultClient as a singleton, to be injected where i needed.
With this i can renew the token, but when Max ttl is reached renew is not possible anymore.
When renew is not possible, i need to inicialize again the IVaultClient, but beeing this a singleton, i beliave that replacing this is not good practice. (I could use scopped instance, but it would generate allot of tokens and add stress to the vault.)
So i remember that we could reset the current token and force the get of the new token.
Can you please review my idea and give me your thouths about this.
Is this something that you are willing to accept?
Thanks