Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list of aws roles #137

Closed
leowaisblatt opened this issue May 6, 2020 · 8 comments
Closed

list of aws roles #137

leowaisblatt opened this issue May 6, 2020 · 8 comments
Assignees
Milestone

Comments

@leowaisblatt
Copy link

It would be very useful if there were a way to get a list of aws roles (http call to /v1/aws/roles)

@rajanadar rajanadar self-assigned this May 7, 2020
@rajanadar rajanadar added this to the vnext milestone May 7, 2020
@rajanadar
Copy link
Owner

@leowaisblatt I have published 1.4.0.2 with this ability.
Please upgrade the version and let me know if any issues.

@leowaisblatt
Copy link
Author

leowaisblatt commented May 7, 2020

thanks! @rajanadar. Pls note that the Http Method expected from vault is LIST, you are sending GET and it fails.

@rajanadar
Copy link
Owner

Ohh oh. That's a silly bug on my side. I'll fix it in a couple of hours and get a new package out. Thanks for the instant feedback.

@rajanadar
Copy link
Owner

Meanwhile you can use the vault settings beforeapirequest handler to add the list query string if that is the url

@leowaisblatt
Copy link
Author

leowaisblatt commented May 7, 2020

it only works with Http Method= LIST.
In the meantime I downloaded a version from git and fixed it on my local so I can move on.
thanks!

@rajanadar
Copy link
Owner

It will also work with http get, you need to append a query string of ?list=true

Anyways I'll fix it tonight

@rajanadar
Copy link
Owner

@leowaisblatt please try 1.4.0.3. it should be fixed now.

@leowaisblatt
Copy link
Author

looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants