feat: try SSH keys before HTTPS for github packages without protocol #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much! |
|
Published to |
This was referenced Mar 15, 2021
Merged
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #850.
If no protocol is specified for a github URL, try the SSH url followed by the HTTPS url. If a protocol is specified, only try that one: assume that people have put in the url correctly.
We try SSH first because HTTPS might prompt for credentials for private repos, while SSH fails silently.
The graphical glitch where the password prompt pops up and disappears if the progress bar updates persists: I'm okay with that because I can't see how you could manage to install a package without either an SSH key or having signed in to GitHub, in which case you're hopefully expecting it.