From 72b3a6c666f214bf7e8778a615f768bbc7bf5b68 Mon Sep 17 00:00:00 2001 From: abnud1 Date: Thu, 26 Mar 2020 23:25:34 +0200 Subject: [PATCH] changed requests batch size to 8 by default instead of number of cpus added cli option to override this batch size modified: bin/ncu modified: lib/versionmanager.js --- bin/ncu | 1 + lib/versionmanager.js | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/bin/ncu b/bin/ncu index 3c42db96..54326f2c 100755 --- a/bin/ncu +++ b/bin/ncu @@ -46,6 +46,7 @@ program .option('-t, --greatest', 'find the highest versions available instead of the latest stable versions') .option('--timeout ', 'a global timeout in ms') .option('-u, --upgrade', 'overwrite package file') + .option('--requests-batch-size ','requests to npm registry are issued in batches whose size is determined by this option',parseInt,8) .option('-x, --reject ', 'exclude packages matching the given string, comma-or-space-delimited list, or /regex/') .option('-v, --version', pkg.version, () => { console.log(pkg.version); diff --git a/lib/versionmanager.js b/lib/versionmanager.js index e259a81e..7d3d69fa 100644 --- a/lib/versionmanager.js +++ b/lib/versionmanager.js @@ -8,7 +8,6 @@ const versionUtil = require('./version-util.js'); const packageManagers = require('./package-managers'); const prompts = require('prompts'); const pMap = require('p-map'); -const os = require('os'); // keep order for setPrecision const DEFAULT_WILDCARD = '^'; @@ -256,7 +255,8 @@ function upgradePackageDefinitions(currentDependencies, options) { json: options.json, loglevel: options.loglevel, enginesNode: options.enginesNode, - timeout: options.timeout + timeout: options.timeout, + batchSize: options.requestsBatchSize }).then(latestVersions => { const upgradedDependencies = upgradeDependencies(currentDependencies, latestVersions, { @@ -456,8 +456,7 @@ function queryVersions(packageMap, options = {}) { return cint.keyValue(packageList[i], version); }); } - - return pMap(packageList,getPackageVersionProtected,{concurrency: os.cpus().length}) + return pMap(packageList,getPackageVersionProtected,{concurrency: options.batchSize}) .then(zipVersions) .then(_.partialRight(_.pickBy, _.identity)); } @@ -562,5 +561,6 @@ module.exports = { isUpgradeable, queryVersions, upgradeDependencies, - upgradeDependencyDeclaration + upgradeDependencyDeclaration, + getPackageManager };