Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip-licenses does not support packages with license files named "COPYING" #59

Closed
johnthagen opened this issue Jan 25, 2020 · 1 comment

Comments

@johnthagen
Copy link
Contributor

johnthagen commented Jan 25, 2020

It is somewhat common (as I've found trying to ensure that all of my packages have license files in a pip-licenses report) for packages to use COPYING as their license file name.

See this reference in a setuptools issue: pypa/setuptools#1636 (comment)

In the same way that README files are automatically grafted into the source distribution, it would be nice if LICENSE / COPYING files were also included by default

Currently pip-licenses cannot find these license files due to this code:

license_file_base = os.path.join(pkg.location, pkg_dirname, 'LICENSE*')

Could this be expanded to include COPYING* as well?

Example:

@johnthagen johnthagen changed the title pip-licenses does not support packages with LICENSE named "COPYING" pip-licenses does not support packages with license files named "COPYING" Jan 25, 2020
@raimon49
Copy link
Owner

Thanks for the report.

Could this be expanded to include COPYING* as well?

It is possible to find a match for LICENSE* / COPYING* in the distribution. Will be implemented soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants