Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar inconsistencies with collapse behavior #3553

Closed
codealchemy opened this issue Sep 29, 2022 · 2 comments
Closed

Sidebar inconsistencies with collapse behavior #3553

codealchemy opened this issue Sep 29, 2022 · 2 comments
Milestone

Comments

@codealchemy
Copy link
Contributor

codealchemy commented Sep 29, 2022

Describe the bug

Side navigation with multiple groups (such as static links in addition to configured models) can move around depending on the state of a given dropdown within the side navigation.

Example using the dummy app from /spec

collapse-nav-default

Reproduction steps

Start demo app, visit the dashboard.

Expected behavior

Side navigation width and group stacking to be static / consistent.

Additional context

  • rails version: 7.0.x
  • rails_admin version: master branch
  • rails_admin npm package version: master branch
  • full stack trace (if there's an exception) N/A

Add any other context about the problem here.

Collapsable sidebar introduced in e8cb8ed

@codealchemy codealchemy added this to the 3.1.0 milestone Sep 29, 2022
@mshibuya
Copy link
Member

mshibuya commented Oct 1, 2022

Sorry about this, it was broken by ef76fce and fixed in the master now.

@codealchemy
Copy link
Contributor Author

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants