Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk: refactor channels epics on its own module #2030

Closed
andrevmatos opened this issue Aug 3, 2020 · 1 comment
Closed

sdk: refactor channels epics on its own module #2030

andrevmatos opened this issue Aug 3, 2020 · 1 comment
Labels
good first issue Good for newcomers refactor sdk 🖥

Comments

@andrevmatos
Copy link
Contributor

andrevmatos commented Aug 3, 2020 •
edited by taleldayekh
Loading

The channels epics are already >1000 loc. I see the relation to the services. But I would eventually suggest to provide them their own module. Then the udc withdraw could be exported into this module as well (maybe more). They should be independent from the rest of the epics of the services.

Originally posted by @weilbith in #2018
@andrevmatos andrevmatos mentioned this issue Aug 3, 2020
Merged
3 tasks
@taleldayekh taleldayekh changed the title sdk: refactor UDC epics on its own module sdk: refactor channels epics on its own module Jun 21, 2021
@taleldayekh
Copy link
Contributor

Has been tackled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor sdk 🖥
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrevmatos @taleldayekh