Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raiden API compatibility discussion - transfer lock timeout #1710

Closed
weilbith opened this issue Jun 16, 2020 · 0 comments · Fixed by #1978
Closed

Raiden API compatibility discussion - transfer lock timeout #1710

weilbith opened this issue Jun 16, 2020 · 0 comments · Fixed by #1978
Assignees
@andrevmatos
Labels
cli 🔤 Command-line SDK-based Node.js Client issues discussion 💬 Issues that need discussion and decision taking sdk 🖥

Comments

@weilbith
Copy link
Contributor

Description

The Raiden API specifies the optional request parameter lock_timeout when initiating a transfer (careful, because API calls transfer payments). This is not available by the SDK and appears to follow a different strategy. This seem to be a similar compatibility discussion as for the reveal timeout (#1656).

Acceptance criteria

  • decision how to handle this parameter to be comptible
  • cli endpoints got adjusted to decision
  • sdk may provide new feature based on decision

Tasks

  • [ ]
@weilbith weilbith added sdk 🖥 discussion 💬 Issues that need discussion and decision taking cli 🔤 Command-line SDK-based Node.js Client issues labels Jun 16, 2020
@weilbith weilbith mentioned this issue Jun 16, 2020
Merged
3 tasks
@andrevmatos andrevmatos self-assigned this Jul 27, 2020
@andrevmatos andrevmatos mentioned this issue Jul 27, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrevmatos andrevmatos

Labels
cli 🔤 Command-line SDK-based Node.js Client issues discussion 💬 Issues that need discussion and decision taking sdk 🖥
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sdk,cli: expose and use transfer's lockTimeout raiden-network/light-client
2 participants
@andrevmatos @weilbith