Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose transfer secret on SDK #1708

Closed
weilbith opened this issue Jun 16, 2020 · 4 comments · Fixed by #1722
Closed

Expose transfer secret on SDK #1708

weilbith opened this issue Jun 16, 2020 · 4 comments · Fixed by #1722
Assignees
Labels
cli 🔤 Command-line SDK-based Node.js Client issues sdk 🖥

Comments

@weilbith
Copy link
Contributor

Description

The Raiden API for payments (be aware that SDK calls payments transfers) defines the output format with the secret property. This property is simply not exposed by the RaidenTransfer object at the SDK. Therefor the cli can not access.

Acceptance criteria

  • RaidenTransfer has the secret property
  • the cli adopts to access this value on transfer to payment formatting

Tasks

  • [ ]
@weilbith weilbith added sdk 🖥 cli 🔤 Command-line SDK-based Node.js Client issues labels Jun 16, 2020
@christianbrb
Copy link
Contributor

@weilbith Is this needed for the train demo?

@weilbith
Copy link
Contributor Author

I don't think so.
This would mean that the user has the need parse the secret property of the returned objects to do something with in. For the moment it is simply empty.
^--- @eorituz ?

@eorituz
Copy link

eorituz commented Jun 16, 2020

Nope, I do not need the secret.
I can't really think of a scenario where someone who uses the cli will actually need the secret.
So I don't think we should put too much effort into it at all.

@weilbith
Copy link
Contributor Author

Yeah. But is should be a small thing to do. I already discussed a quick solution with Andre.

The point is that if you do such decisions already now, you will never switch the mode to clean all that stuff up. You'll simply continue to do new stuff and always say I'll do this later. So I'm fine that we need to get a first "interpretation" of the API spec ready so you have everything for the demo. But in general I would recommend to slow down afterwards and clean up before we continue. Slow development moves products fast on a long term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli 🔤 Command-line SDK-based Node.js Client issues sdk 🖥
Projects
None yet
4 participants