-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose transfer secret on SDK #1708
Comments
@weilbith Is this needed for the train demo? |
I don't think so. |
Nope, I do not need the secret. |
Yeah. But is should be a small thing to do. I already discussed a quick solution with Andre. The point is that if you do such decisions already now, you will never switch the mode to clean all that stuff up. You'll simply continue to do new stuff and always say I'll do this later. So I'm fine that we need to get a first "interpretation" of the API spec ready so you have everything for the demo. But in general I would recommend to slow down afterwards and clean up before we continue. Slow development moves products fast on a long term. |
Description
The Raiden API for payments (be aware that SDK calls payments transfers) defines the output format with the
secret
property. This property is simply not exposed by theRaidenTransfer
object at the SDK. Therefor thecli
can not access.Acceptance criteria
RaidenTransfer
has thesecret
propertycli
adopts to access this value on transfer to payment formattingTasks
The text was updated successfully, but these errors were encountered: