Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel identifier can be undefined by interface definition #1657

Closed
2 tasks
weilbith opened this issue Jun 9, 2020 · 0 comments · Fixed by #1722
Closed
2 tasks

Channel identifier can be undefined by interface definition #1657

weilbith opened this issue Jun 9, 2020 · 0 comments · Fixed by #1722
Assignees
@andrevmatos
Labels
cli 🔤 Command-line SDK-based Node.js Client issues sdk 🖥

Comments

@weilbith
Copy link
Contributor

weilbith commented Jun 9, 2020

Description

In PR #1636 it has turned out that the id field of the interface for
a RaidenChannel can be undefined. Due to out meeting and Andre his
comment this is a due to the history of the SDK and is not the case anymore. So in fact the identifier is never undefined, but Typescript can't know. This should be simply fixed.

Acceptance criteria

  • RaidenChannel.id can be never undefined

Tasks

  • remove optionality of id field in interface definition of SDK
  • remove unnecessary handling of undefined id in cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrevmatos andrevmatos

Labels
cli 🔤 Command-line SDK-based Node.js Client issues sdk 🖥
Projects
None yet
Milestone
No milestone
2 participants
@andrevmatos @weilbith