Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to transfer whole balance on-chain #1392

Closed
andrevmatos opened this issue Apr 22, 2020 · 0 comments · Fixed by #1393
Closed

Provide a way to transfer whole balance on-chain #1392

andrevmatos opened this issue Apr 22, 2020 · 0 comments · Fixed by #1393
Assignees
Labels
enhancement New feature or request sdk 🖥

Comments

@andrevmatos
Copy link
Contributor

andrevmatos commented Apr 22, 2020

Description

As Kelsos, I want to be able to empty an account (e.g. subkey) of ETH and tokens, by transfering entire balance to some other account (e.g. main account).
There're a couple of long-standing TODO in source for this.

* TODO: expose a nice way to transfer ALL, considering gas price & limit

* TODO: expose a nice way to transfer ALL tokens

Needed for #1365

Acceptance criteria

  • I can call SDK's method with special parameters to specify I want to transfer entire balance to another account
  • I can call SDK's method with special parameters to specify I want to transfer entire ETH balance to another account
    • This is trickier, as SDK needs to consider gas cost on this last tx, so the tx succeeds and the remaining balance is zero

Tasks

  • [ ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sdk 🖥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant