Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade test environment and integration tests to work with latest commit before v0.37 #1254

Closed
6 of 7 tasks
christianbrb opened this issue Mar 30, 2020 · 9 comments
Closed
6 of 7 tasks
Assignees
Labels
8 infrastructure 🚧 Tests, CI, and general project infrastructure

Comments

@christianbrb
Copy link
Contributor

christianbrb commented Mar 30, 2020

Description

Upgrade

Acceptance criteria

  • dApp is working with the test environment
  • The integration test is working
  • Other devs than Kelsos are able to execute it the next time
@christianbrb christianbrb added the infrastructure 🚧 Tests, CI, and general project infrastructure label Mar 30, 2020
@christianbrb christianbrb added this to the Product Backlog milestone Mar 30, 2020
@kelsos
Copy link
Contributor

kelsos commented Apr 1, 2020

A contract deployment is not required since we use the same deployment as the python client.

For the hub we need to update the testenv001 tag on docker to the v0.200.0-rc3 commit.
Then redeploying should be easy.

For the integration image we need to:

  • Update Raiden (this will also help to deploy the newer version of raiden-contracts)
  • Update PFS
  • Check if synapse needs update (?)

@christianbrb christianbrb changed the title Upgrade test environment to work with v0.200.0-rc3 - Goat for Azazel Upgrade test environment and integratin tests to work with v0.200.0-rc3 - Goat for Azazel Apr 2, 2020
@christianbrb christianbrb changed the title Upgrade test environment and integratin tests to work with v0.200.0-rc3 - Goat for Azazel Upgrade test environment and integration tests to work with v0.200.0-rc3 - Goat for Azazel Apr 2, 2020
@christianbrb christianbrb added the 8 label Apr 2, 2020
@christianbrb christianbrb removed this from the Product Backlog milestone Apr 2, 2020
@christianbrb
Copy link
Contributor Author

The documentation also needs to be updated, at least https://lightclient.raiden.network/docs/connecting/#raiden-light-client-test-environment (Raiden version)

@nephix
Copy link
Contributor

nephix commented Apr 7, 2020

I made some adjustments to the hub (updated the TTT token address) which are already on https://hub.raiden.network, but it's still offline.

Whenever I ran the deployment in tower though, the same 4 week old raiden python image seems to be get started. Instead, the updated one from yesterday should be used.

My attempts to stop and remove the related docker containers and images didn't succeed. I thought that removing them and doing a docker pull raiden-network/raiden:testenv001 would fix the issue.

Via docker ps I can also see that the python client keeps restarting over and over again.

Seems more like a DevOps problem to me

Related: https://github.com/raiden-network/raiden-hub/issues/10

@nephix nephix removed their assignment Apr 7, 2020
@christianbrb
Copy link
Contributor Author

christianbrb commented Apr 7, 2020

As the newest contracts are going to be deprecated, we should the latest version which support the contracts v0.36

@christianbrb christianbrb changed the title Upgrade test environment and integration tests to work with v0.200.0-rc3 - Goat for Azazel Upgrade test environment and integration tests to work with latest commit before v0.37 Apr 7, 2020
@andrevmatos
Copy link
Contributor

  • Contracts version: v0.36.2 (commit e1b5e5b8a4d060998be504b19c5748c0994494c5, same deployment/addresses as of v0.36.0, but the one pinned to raiden before 0.37 bump, so we should go with it)
  • Raiden version: ea7025739b460f940c26616ca1fccdb739b218ed (commit right before 0.37 bump)
  • Services version: 100fecf0d8c21ee68d8afbea912b67167ec7aad3 - this is the commit before bump to rc3/0.37, but please, give it a run on integration image, to make sure it'll play along

@nephix
Copy link
Contributor

nephix commented Apr 8, 2020

The contract versions in the light client have been changed in #1303

Pointing the testenv001 to the correct commit and downgrading the services is still in progress by @eorituz

@nephix nephix self-assigned this Apr 8, 2020
@nephix
Copy link
Contributor

nephix commented Apr 8, 2020

Integration test image part of this ticket has been moved to #1307

@eorituz
Copy link

eorituz commented Apr 8, 2020

Updated the Docker image raidennetwork/raiden:testenv001 as well as the raiden service bundle to be compliant with the versions Andre determined three comments above.
The Raiden Hub is also updated.

@nephix
Copy link
Contributor

nephix commented Apr 9, 2020

I have tested direct and mediated transfers with the latest testenv001 tag and it mostly worked.
I wasn't able to mediate through the hub and created https://github.com/raiden-network/raiden-hub/issues/11 with the steps

The integration test image part of this ticket is here: #1307
And the documentation part here: #1316

@nephix nephix closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8 infrastructure 🚧 Tests, CI, and general project infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants