Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xtensa lx6 #22

Merged
merged 4 commits into from
Aug 3, 2021
Merged

Xtensa lx6 #22

merged 4 commits into from
Aug 3, 2021

Conversation

pyaillet
Copy link
Contributor

Hi !

Thank you for this crate I'm using it with a shared i2c bus on an esp32.

Would you be interested in adding support for this kind of device ?
If so, here is a PR.

I'm quite new to the Rust and embedded world so comments and suggestions are more than welcomed.

Copy link
Owner

@Rahix Rahix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

yes, support for new devices is very welcome! I have one big question implementation wise, see comment below.

Co-authored-by: Rahix <rahix@rahix.de>
@Rahix
Copy link
Owner

Rahix commented Aug 2, 2021

Currently CI is still failing because the xtensa crate does not compile on stable rust. I'll have to take a look...

@pyaillet
Copy link
Contributor Author

pyaillet commented Aug 2, 2021

xtensa is not supported by official Rust and LLVM, to use it we must use a LLVM fork maintained by espressif, and a rust fork.

I can try to setup an action to handle this, but if the use of the fork is a no go for you, no problem.

@Rahix
Copy link
Owner

Rahix commented Aug 2, 2021

I can try to setup an action to handle this, but if the use of the fork is a no go for you, no problem.

I would rather not try to add this... Can you check whether a cargo +nightly build --all-features or a cargo +nightly check --all-features passes? If yes, I'd split the supported archs into "builds on stable" and "checks on nightly" groups and have two jobs for them.

@pyaillet
Copy link
Contributor Author

pyaillet commented Aug 3, 2021

Both seems to work fine: https://github.com/pyaillet/shared-bus/runs/3228754084?check_suite_focus=true

However I'm not sure to understand how you want to split this.

@Rahix
Copy link
Owner

Rahix commented Aug 3, 2021

Thanks. I'll take it from here, you don't need to worry about it :)

@Rahix Rahix merged commit 6c90ee6 into Rahix:main Aug 3, 2021
@Rahix Rahix mentioned this pull request Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants