-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unrealistic correlation between sterodynamic and VLM components due to default Monte Carlo seed (1234
)
#349
Comments
This is a common default, but usually not an issue because of different relationships between the random number draws and the sea level outcome. In this case, I guess the underlying statistical form is similar enough it is a problem. This does suggest we need some standard method for assigning a unique default seed to each module, but for the moment, see what happens if you change the seed. Seed is a model parameter, so no code change is needed to affect this; it should be possible to do this in the experiment file by specifying the seed parameter. |
Hi @bobkopp! Thanks for your quick response to this issue. I followed your suggestion and run a test by specifying a different seed for VLM in the experiment configuration file: k14vlm:
module_set: "kopp14"
module: "verticallandmotion"
options:
seed: 5678 So this should specify the seed to be The figures below show the comparison between the original config file and a new run with the modified config file (
In the new experiment, the interaction effects is now very small, such that the sum of variances across components now closely matches the total variance: I think that this will impact the projection of total sea level change. You can see this by comparing the 5-95 interval from |
This should be addressed systematically, but for the moment, why don't you do a pull request to change the default seed for the vlm module? |
I have observed an artificial correlation between the sterodynamic and vertical land motion components in the FACTS output, which is visible in scatter plots. See an example for the tide gauge location at Tema (Ghana) using workflow '1e':
The correlation appears to arise from the default use of the same random seed that is set by default to
1234
for the Monte Carlo sampling:See in tlm_sterodynamics_postprocess.py:
facts/modules/tlm/sterodynamics/tlm_sterodynamics_postprocess.py
Line 257 in 7f7b0cf
and in kopp14_verticallandmotion_postprocess.py
facts/modules/kopp14/verticallandmotion/kopp14_verticallandmotion_postprocess.py
Line 156 in 7f7b0cf
The unintended correlation can lead to misleading variance decomposition that overstate the role of the interaction effects where the variance of the total is larger than the sum of the components variances. This is particularly visible for any location of a sizable sea level change due to vertical land motion, such as Tema (Ghana):
From the figures above, the "Interaction Effect" often appears to be more than 20% of the variance in total sea level change, which I suspect is mostly because of the artificial correlation between the sterodynamic and vertical land motion components. I wonder how to address this. Change the default seed to make sure they are different across the components / modules? Are there any other module that apply a Monte Carlo sampling with a default seed of
1234
?The text was updated successfully, but these errors were encountered: