From 2b29c43c788de7f6d5976b589f74c56dd5b304c0 Mon Sep 17 00:00:00 2001 From: Kyle Finley Date: Mon, 9 Dec 2019 15:11:50 -0800 Subject: [PATCH 1/2] removed "locked" condition from `Stack.requires`, update changelog --- CHANGELOG.md | 4 ++++ src/runway/embedded/stacker/stack.py | 6 ------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 40a58e822..8aaa7b53d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ### Added - Allow single-binary use of bundled yamllint +### Changed +- embedded stacker will not resolve dependancies for `locked` stacks when they rely on other stacks + - accepted upstream in https://github.com/cloudtools/stacker/pull/746 + ## [1.3.3] - 2019-11-26 ### Changed - Updated `runway test` error message to give direction on next steps when no tests are defined diff --git a/src/runway/embedded/stacker/stack.py b/src/runway/embedded/stacker/stack.py index aa5ab81b4..950fcd548 100644 --- a/src/runway/embedded/stacker/stack.py +++ b/src/runway/embedded/stacker/stack.py @@ -85,12 +85,6 @@ def required_by(self): @property def requires(self): - # By definition, a locked stack has no dependencies, because we won't - # be performing an update operation on the stack. This means, resolving - # outputs from dependencies is unnecessary. - if self.locked and not self.force: - return [] - requires = set(self.definition.requires or []) # Add any dependencies based on output lookups From d3803b79af3120f5f4363c1bbbc74cee0f031353 Mon Sep 17 00:00:00 2001 From: Kyle Finley Date: Tue, 10 Dec 2019 10:02:20 -0800 Subject: [PATCH 2/2] add patch note to setup.py --- setup.py | 1 + 1 file changed, 1 insertion(+) diff --git a/setup.py b/setup.py index 7eaa7e276..8b7558312 100644 --- a/setup.py +++ b/setup.py @@ -40,6 +40,7 @@ # and the following patches applied # https://github.com/cloudtools/stacker/pull/731 (CAPABILITY_AUTO_EXPAND) # https://github.com/cloudtools/stacker/pull/744 (diffs via CFN changesets) + # https://github.com/cloudtools/stacker/pull/746 (locked stack dependencies) # and the following files/folders deleted: # * tests # * blueprints/testutil.py