-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
binary package doesn't work on ubuntu 16.04 #110
Comments
ubuntu 16.04 seems to have glibc 2.23 centos7 seems to have glibc 2.17 So for maximum compatibility it would be good if we could build the linux package on centos7 somehow. |
github actions doesn't offer centos7 but says to use Docker if you want other environments. Using the As long as all our dependencies are happy with python 3.6 that should be fine. |
I was thinking of building w. Py3.9 for the next release because of #109 (which can probably be fixed in Python for older versions). So the hypothesis is that with I do tend to think that linux users will be more likely to be able to |
Time to make some manylinux binary wheels! |
That's the official-ish Python way? Let's try it. |
@kaushik-work for this use case I'm targeting here which is someone using vscode to edit CWL on a remote (linux) host, having benten install seamlessly is still a key part of the experience. |
@mr-c we arn't building binary wheels, we're building standalone executables with pyinstaller. Unfortunately, manylinux considers this to be out of scope: pypa/manylinux#255 The recommendation is to fork manylinux and reenable building with shared libraries, so I'm trying that. |
See #111 |
(Confirmed that the 'manylinux' build works on Ubuntu 16.04). |
The binary package is mostly self-contained but it still relies on glibc:
I think the problem is we build with
ubuntu-latest
which is 18.04. According to https://github.com/actions/virtual-environmentsubuntu-16.04
is also available so we should see how hard it would be to build on that instead.I'm also wondering now if this package is going to work on centos7.
The text was updated successfully, but these errors were encountered: