From 95ef9fb69398e5c928836d8e652db6b53f78d817 Mon Sep 17 00:00:00 2001 From: Michal Kuratczyk Date: Thu, 29 Apr 2021 09:07:44 +0200 Subject: [PATCH 1/2] More accurate ack mode description in the UI I ran into this when working on metrics. This option sets `no_ack = true` which means an automatic ack. However, the old description, `Ack message requeue false`, suggests to me that there is a manual ack. I spent a lot of time trying to find a bug in the metrics code that counted this as an auto-acked message, when in fact it was an auto-acked message. :) --- deps/rabbitmq_management/priv/www/js/tmpl/queue.ejs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/rabbitmq_management/priv/www/js/tmpl/queue.ejs b/deps/rabbitmq_management/priv/www/js/tmpl/queue.ejs index e3ac572fde54..d6c4c2836043 100644 --- a/deps/rabbitmq_management/priv/www/js/tmpl/queue.ejs +++ b/deps/rabbitmq_management/priv/www/js/tmpl/queue.ejs @@ -310,7 +310,7 @@ From c6902ac49f79dcf949d33d61601fe99494812d12 Mon Sep 17 00:00:00 2001 From: Michal Kuratczyk Date: Thu, 29 Apr 2021 14:20:49 +0200 Subject: [PATCH 2/2] Remove "requeue false" As discussed, since requeuing is impossible with auto ack, let's remove this part. --- deps/rabbitmq_management/priv/www/js/tmpl/queue.ejs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/rabbitmq_management/priv/www/js/tmpl/queue.ejs b/deps/rabbitmq_management/priv/www/js/tmpl/queue.ejs index d6c4c2836043..86c82ed31562 100644 --- a/deps/rabbitmq_management/priv/www/js/tmpl/queue.ejs +++ b/deps/rabbitmq_management/priv/www/js/tmpl/queue.ejs @@ -310,7 +310,7 @@