Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pallet-nfts): DelegateApprovalConflicts #402

Open
chungquantin opened this issue Dec 9, 2024 · 0 comments
Open

chore(pallet-nfts): DelegateApprovalConflicts #402

chungquantin opened this issue Dec 9, 2024 · 0 comments

Comments

@chungquantin
Copy link
Collaborator

Link to the discussion: #387 (comment)

Note: Implementation was initially inspired from AZ: https://github.com/Cardinal-Cryptography/PSP34/blob/main/data.rs#L120

Description

The current implementation throws an error DelegateApprovalConflicts when attempting to revoke approval for a single token if the operator already has approval for all tokens. This issue proposes revisiting whether this error is necessary, as its removal does not appear to impact other methods, such as transfer, or introduce any security concerns.

This might be an edge case, but its worth considering why someone might have these approvals. If it is purely for the sake of listing it on a market place, say some marketplace contract, then what might the expected usage be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant