Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch add-pallet needs to check for duplicated entries. #63

Closed
al3mart opened this issue Mar 13, 2024 · 2 comments
Closed

Branch add-pallet needs to check for duplicated entries. #63

al3mart opened this issue Mar 13, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@al3mart
Copy link
Contributor

al3mart commented Mar 13, 2024

The command pop add pallet in branch add-pallet will inject the different features for the pallet independently of these being already present in the file.

This can be reproduce by running twice the same command, for instance: pop add pallet template -r runtime/src/lib.rs within a parachain project.

It will also instantiate multiple times the same pallet in the runtime.

@al3mart al3mart added the bug Something isn't working label Mar 13, 2024
@evilrobot-01
Copy link
Contributor

The entry API to toml_edit could be useful for this:

let Item::Table(settings) =
network_config.entry("settings").or_insert(Item::Table(Table::new()))

@AlexD10S
Copy link
Collaborator

I close the issue for now as we still don't have the pop add pallet functionality

@AlexD10S AlexD10S closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants