Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 1.2.0? #39

Closed
polettif opened this issue Oct 7, 2024 · 10 comments
Closed

release 1.2.0? #39

polettif opened this issue Oct 7, 2024 · 10 comments

Comments

@polettif
Copy link
Collaborator

polettif commented Oct 7, 2024

With the changes in #37 and the pending updates in tidytransit we should push a new release of gtfsio. Version 1.2.0 seems appropriate to me. Could you initiate that, @dhersz?

I think we'll leave #38 to a later release, @mpadge?

@mpadge
Copy link
Collaborator

mpadge commented Oct 7, 2024

Thanks @polettif! I'd be able to find time this week to convert all file calls to fs versions for this release if that would help?

@polettif
Copy link
Collaborator Author

polettif commented Oct 7, 2024

Thanks @polettif! I'd be able to find time this week to convert all file calls to fs versions for this release if that would help?

Yes, that would be great!

@dhersz
Copy link
Collaborator

dhersz commented Oct 7, 2024

Hi guys, sorry for my long absence. I have started a new job and had to move to a different city and to enroll on a training course for the last two months, so I was having some trouble adapting to the new schedule. Doing better time-wise now, though :)

If I understood correctly, @mpadge will make the proposed changed first and then we release the new version? Thanks!

@mpadge
Copy link
Collaborator

mpadge commented Oct 8, 2024

@dhersz @polettif I've pinged you both as reviewers for #40. I also note that NEWS.md hasn't been updated at all, and that definitely should be done prior to release. Thanks!

@dhersz
Copy link
Collaborator

dhersz commented Oct 8, 2024

Thanks @mpadge. I can update the news file after @polettif reviews the PR as well.

@mpadge
Copy link
Collaborator

mpadge commented Oct 8, 2024

And BTW Daniel, congrats on new job and new city! Great to hear!

@polettif
Copy link
Collaborator Author

I think we're ready to go @dhersz. I just pushed an update to the news file, please change/edit as you see fit.

@dhersz
Copy link
Collaborator

dhersz commented Oct 11, 2024

Cool, thanks! Will make one last revision and submit it.

@dhersz
Copy link
Collaborator

dhersz commented Oct 14, 2024

Done. Thank you guys for all the work you've put into this release!

@dhersz dhersz closed this as completed Oct 14, 2024
@mpadge
Copy link
Collaborator

mpadge commented Oct 14, 2024

Thanks @dhersz, this is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants