Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url_relative test fails with libxml2 2.9.10 #277

Closed
QuLogic opened this issue Nov 6, 2019 · 2 comments
Closed

url_relative test fails with libxml2 2.9.10 #277

QuLogic opened this issue Nov 6, 2019 · 2 comments

Comments

@QuLogic
Copy link

QuLogic commented Nov 6, 2019

Issue Description and Expected Result

The automatic rebuilds fail again with the libxml2 2.9.10 release.

Reproducible Example

Run build (including tests) on Fedora Rawhide or other system with libxml2 2.9.10.

Last 13 lines of output:
  > 
  > test_check("xml2")
  This is libxml2 version 2.9.10 
  -- 1. Failure: url_relative (@test-url.R#22)  ----------------------------------
  url_relative("http://hadley.nz/a/c", "http://hadley.nz/") not equal to "../a/c".
  1/1 mismatches
  x[1]: "a/c"
  y[1]: "../a/c"
  
  == testthat results  ===========================================================
  [ OK: 390 | SKIPPED: 4 | WARNINGS: 0 | FAILED: 1 ]
  1. Failure: url_relative (@test-url.R#22) 

I guess this is because the fix in 9b5426e does a string comparison of versions, for which '2.9.10' < '2.9.9'. I'm not sure how you can do a proper semver comparison in R.

Session Info It's an automated build, so I can't really get this, sorry. You can check the root.log in the build link above for installed packages.
@jimhester
Copy link
Member

jimhester commented Nov 6, 2019

Thanks, should now be fixed by using a semantic comparison rather than alphanumeric.

@QuLogic
Copy link
Author

QuLogic commented Nov 6, 2019

Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants