Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider sorting instead of hashing for uniqueness #736

Closed
hadley opened this issue Jan 8, 2020 · 1 comment
Closed

Consider sorting instead of hashing for uniqueness #736

hadley opened this issue Jan 8, 2020 · 1 comment

Comments

@hadley
Copy link
Member

hadley commented Jan 8, 2020

https://news.ycombinator.com/item?id=21985246

This would allow us to use radix sort of for integer indices, which would help us to match data.table performance when grouping in dplyr.

@DavisVaughan
Copy link
Member

See #1361 (comment) for explanation of why we probably don't want switch all of the dictionary functions over to sorting

We did expose vec_locate_sorted_groups() (which uses radix ordering) for use in dplyr's group_by() tidyverse/dplyr#6297, which was really the original motivation of this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants