Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on aarch64 Windows #106

Closed
gaborcsardi opened this issue Oct 2, 2023 · 5 comments · Fixed by #107
Closed

Fix build on aarch64 Windows #106

gaborcsardi opened this issue Oct 2, 2023 · 5 comments · Fixed by #107

Comments

@gaborcsardi
Copy link
Member

Need to create the aarch64 windows libs first at https://github.com/r-windows/bundles/releases and then update the winlibs.R file to download from there. Example in curl: https://github.com/jeroen/curl/blob/master/tools/winlibs.R

@thomasp85
Copy link
Member

@jeroen is this something you have time to look at?

@jeroen
Copy link
Member

jeroen commented Oct 2, 2023

Yes I'll send some PRs this week. It's mostly ready but I am considering to opt-in to the new directX font APIs in cairo and pango while we are at it.

@thomasp85
Copy link
Member

Oh, nice. There's a stub for that in systemfonts as well. When I get the time that should be investigated

@jeroen
Copy link
Member

jeroen commented Oct 5, 2023

Do you case if we enable dwrite support in harfbuzz or not? Or are you not using that functionality from harfbuzz anyway.

@andrjohns
Copy link

Apologies for resurrecting an old issue, but systemfonts still fails to install on windows aarch64:

> remotes::install_github("r-lib/systemfonts")
Using GitHub PAT from the git credential store.
Downloading GitHub repo r-lib/systemfonts@HEAD
── R CMD build ─────────────────────────────────────────────────────
   checking for file 'C:\Users\andrew\AppData\Local\Temp\RtmpItWQur\✔  checking for file 'C:\Users\andrew\AppData\Local\Temp\RtmpItWQur\remotes54c17533a22\r-lib-systemfonts-55888ff/DESCRIPTION'
─  preparing 'systemfonts': (449ms)
✔  checking DESCRIPTION meta-information ... 
─  cleaning src
─  checking for LF line-endings in source and make files and shell scripts
─  checking for empty or unneeded directories
─  looking to see if a 'data/datalist' file should be added
─  building 'systemfonts_1.1.0.9000.tar.gz'
   Warning: file 'systemfonts/cleanup' did not have execute permissions: corrected
   Warning: file 'systemfonts/configure' did not have execute permissions: corrected
   
Installing package into 'C:/Users/andrew/AppData/Local/R/aarch64-library/4.5'
(as 'lib' is unspecified)
* installing *source* package 'systemfonts' ...
** using staged installation

   **********************************************
   WARNING: this package has a configure script
         It probably needs manual configuration
   **********************************************


** libs
using C++ compiler: 'clang version 17.0.6'
rm -f caches.o cpp11.o dev_metrics.o font_matching.o font_registry.o ft_cache.o string_shape.o font_metrics.o font_fallback.o string_metrics.o emoji.o cache_store.o init.o win/FontManagerWindows.o systemfonts.dll
"C:/PROGRA~1/R-AARC~1/R-devel/bin/Rscript.exe" "../tools/winlibs.R"
clang++ -std=gnu++17  -I"C:/PROGRA~1/R-AARC~1/R-devel/include" -DNDEBUG -I../windows/harfbuzz/include/freetype2 -I'C:/Users/andrew/AppData/Local/R/aarch64-library/4.5/cpp11/include' -w  -I"C:/rtools44-aarch64/aarch64-w64-mingw32.static.posix/include"     -O2 -Wall    -c caches.cpp -o caches.o
clang++ -std=gnu++17  -I"C:/PROGRA~1/R-AARC~1/R-devel/include" -DNDEBUG -I../windows/harfbuzz/include/freetype2 -I'C:/Users/andrew/AppData/Local/R/aarch64-library/4.5/cpp11/include' -w  -I"C:/rtools44-aarch64/aarch64-w64-mingw32.static.posix/include"     -O2 -Wall    -c cpp11.cpp -o cpp11.o
clang++ -std=gnu++17  -I"C:/PROGRA~1/R-AARC~1/R-devel/include" -DNDEBUG -I../windows/harfbuzz/include/freetype2 -I'C:/Users/andrew/AppData/Local/R/aarch64-library/4.5/cpp11/include' -w  -I"C:/rtools44-aarch64/aarch64-w64-mingw32.static.posix/include"     -O2 -Wall    -c dev_metrics.cpp -o dev_metrics.o
In file included from caches.cpp:1:
In file included from ./caches.h:7:
./ft_cache.h:9:10: fatal error: 'ft2build.h' file not found
    9 | #include <ft2build.h>
      |          ^~~~~~~~~~~~
1 error generated.

The headers and libraries are in the aarch64 Rtools, would it be easier to use those instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants