Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to styling all supported file types in style_dir() and style_pkg()? #963

Closed
IndrajeetPatil opened this issue Jul 18, 2022 · 3 comments · Fixed by #965
Closed

Default to styling all supported file types in style_dir() and style_pkg()? #963

IndrajeetPatil opened this issue Jul 18, 2022 · 3 comments · Fixed by #965

Comments

@IndrajeetPatil
Copy link
Collaborator

I am wondering if style_dir() and style_pkg() shouldn't style all supported file formats in the directory/package by default.

Is there any reason why the users may wish to format only code in .R files, but not in (e.g.) .Rmd files?

Current default:

filetype = c("R", "Rprofile")

Proposed default:

filetype = c("R", "Rprofile", "Rmd", "Rmarkdown", "Rnw")
@lorenzwalthert
Copy link
Collaborator

Yes. Also thought about it. Did not want to do that in the very beginning though, when formatting of non-R was experimental.

@IndrajeetPatil
Copy link
Collaborator Author

Thanks; good to hear that you also feel the same way about this.

Should I make a PR then?

@lorenzwalthert
Copy link
Collaborator

This issue is also included in #769, although questionable if breaking or not. PR welcome yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants