Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor block_to_rd() #915

Closed
hadley opened this issue Sep 19, 2019 · 2 comments
Closed

Refactor block_to_rd() #915

hadley opened this issue Sep 19, 2019 · 2 comments

Comments

@hadley
Copy link
Member

hadley commented Sep 19, 2019

Most tags can be processed in order, so we could loop over the list of tags once, rather than multiple times. There are three exceptions:

  • @backref has default if not supplied
  • @usage has default if not supplied
  • @aliases NULL prevents default from being added

This could be powered by S3 (by adding a subclass in RoxyTag. It will considerably simplify the code, make it easier to add new tags, and (I suspect) improve performance.

@hadley
Copy link
Member Author

hadley commented Sep 19, 2019

@param, @slot and @field (which call process_def_tag()) currently create a single named list, but it feels like that could be handled in at the topic level.

@hadley
Copy link
Member Author

hadley commented Sep 19, 2019

I just moved backref into block_find_object(); it's possible @usage and @aliases should go there too.

@hadley hadley closed this as completed in 29db38f Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant