Use more generic x-r-run
over ide:run
#1604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to switch us away from
style_hyperlink()
entirely in favor offormat_inline("{.run ...}")
, but it produces some weird text when in the fallback casestyle_hyperlink()
returnstext
unchanged in the fallback case.run {text}
returnstext
styled as{.code }
in the fallback case, i.e. it backticks itSo in the fallback case, if you combine
.run {text}
(backticks) with our usage of{.path }
(single quotes) below, then you end up withWriting '`a.Rd`'
. It seems better to just continue to manually usestyle_hyperlink()
so we have complete control over the fallback view. This case is covered by a test, which is how I learned about it in the first place.roxygen2/R/utils.R
Lines 90 to 93 in db4dd9a