Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer skip_if_not() to skip_if(!) #1762

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

MichaelChirico
Copy link
Contributor

@MichaelChirico MichaelChirico commented Nov 25, 2024

It will give more readable skip messages, currently we get:

• !compiled_by_gcc() is TRUE (1): test-c-api.R:1113:3

Alternatively/additionally, we can use the message= argument to further improve the skip message.

@lionel- lionel- merged commit 474696b into r-lib:main Nov 27, 2024
12 of 13 checks passed
@lionel-
Copy link
Member

lionel- commented Nov 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants