Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaged don't find vignettes created with use-vignette #14

Closed
jimhester opened this issue Mar 2, 2017 · 5 comments
Closed

Packaged don't find vignettes created with use-vignette #14

jimhester opened this issue Mar 2, 2017 · 5 comments
Labels
feature a feature request or enhancement load

Comments

@jimhester
Copy link
Member

Issue by smach
Thursday Sep 17, 2015 at 00:53 GMT
Originally opened as r-lib/devtools#931


Packages don't "find" vignettes created with use-vignette() -- that is, they're not listed in the package help or when runningvignette() and browseVignettes() -- without also running build_vignette(). Issue filed per this Twitter thread https://twitter.com/sharon000/status/644256000451694592

@jimhester jimhester added feature a feature request or enhancement load labels Mar 2, 2017
@jimhester
Copy link
Member Author

Comment by jennybc
Thursday Nov 12, 2015 at 10:22 GMT


What IS the official party line on how to manage vignettes during development?

In your book, vignette workflow addresses the (ephemeral) preview. And development cycle gets at the other end ... when building and installing a package properly.

What about the bit in the middle?

@jimhester
Copy link
Member Author

Comment by hadley
Thursday Nov 12, 2015 at 12:49 GMT


I preview them with Cmd + Shift + K. What else do you need to do during dev?

@jimhester
Copy link
Member Author

Comment by jennybc
Thursday Nov 12, 2015 at 16:02 GMT


I'm thinking about the vignettes relative to what we do for roxygen comment / Rd file (and README.Rmd / README.md?).

The documentation workflow results in persistent help files you can preview in their natural habitat with ?. What's the equivalent for a vignette? The Cmd + Shift + K preview can be a drag because sometimes they take a long time to render.

It's not that I can't figure out how get a rendered vignette. It's about figuring out the most devtools-ish way to get and possibly hold on to them.

@jimhester
Copy link
Member Author

Comment by hadley
Thursday Nov 12, 2015 at 19:11 GMT


Oh hmmmm, maybe we need a vignette() shim to get the dev version?

@hadley
Copy link
Member

hadley commented Aug 9, 2017

I think this needs a fix to install: r-lib/devtools#1578

@hadley hadley closed this as completed Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement load
Projects
None yet
Development

No branches or pull requests

2 participants