-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Personal Makevars is now being ignored #156
Comments
I have experienced the same, with the change that my personal Makevars is not ignored but with This is for C++14 compilation with lldb setting |
My package includes compiled templated C++ code. Using an optimation level below -O1 on Windows is known to throw errors during compilation. I tested this by calling devtools::load_all() using an updated version of pkgbuild and the debugger successfully ran without throwing an error. I would prefer not to have to rely on a fork of pkgbuild. I can get around the issue by setting |
@Andrea-Havron-NOAA I am sorry, but I don't follow. Can you change the flags in the package's |
The package has a |
I think if you set |
@DavisVaughan Is it intentional that you are overwriting R's default
you are using
AFAICT for the more natural Overwriting R's default flags is in general not a good idea, I think, they change quite often, and sometimes it is important to keep them. E.g.:
|
The current semantics, coming from
I should add that only fields that are set using It is hard to say what is the right semantics for a generic |
If I don't set When compiling clock with
When compiling clock with
It looks like:
But I think the last |
I imagine I originally did
|
Yes, and that is intentional in Other environments like Rust have a notion of debug and release builds, maybe we should also have this notion in pkgload as well, not just in pkgbuild. |
For clock it dramatically changes the testing time, from around 60sec with O2 -> 215sec with O0 due to the huge amount of templating which I'm assuming isn't being inlined in the unoptimized version. I'd be in favor of some kind of debug vs release flags |
OK, we can think about how to do it in For now, I'll update pkgbuild to always append the debug flags in debug builds, so using @DavisVaughan of course you'll still need to use |
#151 added new debug capabilities, but I think it also accidentally caused personal Makevars to be ignored, just due to how
local_makevars()
works.It now seems that my Makevars file is being ignored entirely when I
load_all()
, and this is what the compilation line looks like (notice the weird O2 along with O0, which don't come from me):My personal makevars has this in it, not appearing anywhere anymore
If i set
pkg.build_extra_flags
toFALSE
it gets respected again, so I can do that as a workaround for now until this gets fixed againThe text was updated successfully, but these errors were encountered: