Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spell_check doesn't check if spelling is installed #2172

Closed
mikemahoney218 opened this issue Dec 30, 2019 · 2 comments · Fixed by #2173
Closed

spell_check doesn't check if spelling is installed #2172

mikemahoney218 opened this issue Dec 30, 2019 · 2 comments · Fixed by #2173

Comments

@mikemahoney218
Copy link
Contributor

When running devtools::spell_check() on a computer without spelling installed, spell_check fails due to the missing namespace:

> devtools::spell_check()
Error in loadNamespace(name) : there is no package called ‘spelling’

Other functions such as devtools::check_rhub() seem to make use of check_suggested() in interactive sessions to prompt users to install the package if needed, rather than just failing. Would it make sense for this function to do the same?

@jimhester
Copy link
Member

Sure, would be happy to review a PR if you are interested!

@mikemahoney218
Copy link
Contributor Author

Threw up #2173 which I'm pretty sure will do the trick -- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants