From b6fda8144de4b145197c6d38aa6a1bb839678a5c Mon Sep 17 00:00:00 2001 From: hadley Date: Mon, 7 Apr 2014 12:14:51 -0500 Subject: [PATCH] Update check notes for release --- rcmd-notes.md | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/rcmd-notes.md b/rcmd-notes.md index 631088a4b..706cbe502 100644 --- a/rcmd-notes.md +++ b/rcmd-notes.md @@ -1,10 +1,5 @@ The following notes were generated across my local OS X install, ubuntu running on travis-ci and win builder. Response to NOTEs across three platforms below. -* checking package dependencies ... NOTE - - Note about rstudio package included in DESCRIPTION. Will be removed - once rstudioapi package is accepted. - * checking R code for possible problems ... NOTE Found the following calls to attach(): File ‘devtools/R/package-env.r’: @@ -20,3 +15,13 @@ The following notes were generated across my local OS X install, ubuntu running file that is run in a fresh R session. We also ran R CMD check on all reverse dependencies for r-release: https://github.com/wch/devtools-checkresults/blob/master/r-release/00check-summary.txt. The only failure is with NMF - the failing example seems unrelated to devtools, and it's hard to imagine why the package needs devtools at all. + +Compared to the last submission, I have: + +* Switched to using rstudioapi instead of rstudio + +* Incremented the versions of R that Rtools 3.1 matches based on Brian's + comment (overriding the version specification from + http://cran.r-project.org/bin/windows/Rtools/) + +I am aware that devtools does not work on Solaris.